Skip to content

Use varargs in FilteredList and AbstractElementListSelectionDialog #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Jan 15, 2026
Merged

Use varargs in FilteredList and AbstractElementListSelectionDialog #3675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...pse.ui.workbench/eclipseui/org/eclipse/ui/dialogs/AbstractElementListSelectionDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2015 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -186,7 +186,7 @@ public void setValidator(ISelectionStatusValidator validator) {
*
* @param elements the elements of the list.
*/
protected void setListElements(Object[] elements) {
protected void setListElements(Object... elements) {
Assert.isNotNull(fFilteredList);
fFilteredList.setElements(elements);
handleElementsChanged();
Expand Down Expand Up @@ -263,7 +263,7 @@ protected int getSelectionIndex() {
*
* @param selection the indices of the selection.
*/
protected void setSelection(Object[] selection) {
protected void setSelection(Object... selection) {
Assert.isNotNull(fFilteredList);
fFilteredList.setSelection(selection);
}
Expand Down
8 changes: 4 additions & 4 deletions bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/dialogs/FilteredList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2015 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -246,7 +246,7 @@ public FilteredList(Composite parent, int style, ILabelProvider labelProvider, b
*
* @param elements the elements to be shown in the list.
*/
public void setElements(Object[] elements) {
public void setElements(Object... elements) {
if (elements == null) {
fElements = new Object[0];
} else {
Expand Down Expand Up @@ -326,7 +326,7 @@ public void removeSelectionListener(SelectionListener listener) {
*
* @param selection an array of indices specifying the selection.
*/
public void setSelection(int[] selection) {
public void setSelection(int... selection) {
if (selection == null || selection.length == 0) {
fList.deselectAll();
} else // If there is no working update job, or the update job is ready to
Expand Down Expand Up @@ -365,7 +365,7 @@ public int getSelectionIndex() {
*
* @param elements the array of elements to be selected.
*/
public void setSelection(Object[] elements) {
public void setSelection(Object... elements) {
if (elements == null || elements.length == 0) {
fList.deselectAll();
return;
Expand Down
Loading