Skip to content

Migrate ConformanceTestSuite and dependencies to JUnit 5 #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vogella wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate ConformanceTestSuite and dependencies to JUnit 5 #3658

vogella wants to merge 1 commit into from

Conversation

@vogella
Copy link
Contributor

@vogella vogella commented Jan 11, 2026

Migrate the ConformanceTestSuite and its dependent conformance test classes in org.eclipse.jface.tests.databinding to JUnit 5.
Verified with local tests.

@vogella vogella force-pushed the migrate-jface-databinding-conformance-junit5 branch from 34c11eb to 6b7b229 Compare January 11, 2026 14:35
@vogella vogella marked this pull request as draft January 11, 2026 14:35
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026 •
edited
Loading

Test Results

 2 502 files   -   513   2 502 suites   - 513   2h 5m 34s ⏱️ - 1m 32s
 7 189 tests  - 1 069   6 943 ✅  - 1 067  246 💤  - 2  0 ❌ ±0 
20 391 runs   - 3 207  19 606 ✅  - 3 201  785 💤  - 6  0 ❌ ±0 

Results for commit a95e1d5. ± Comparison against base commit e81ba1c.

This pull request removes 1069 tests. 
org.eclipse.core.tests.databinding.AggregateValidationStatusTest ‑ testAggregateValidationStatusValueType
org.eclipse.core.tests.databinding.AggregateValidationStatusTest ‑ testConstructor_DefaultRealm
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeBindingThenModel
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeBindingThenObservables
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeBindingThenTarget
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeModelDisposesBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeModelThenBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeObservablesThenBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeTargetDisposesBinding
org.eclipse.core.tests.databinding.BindingTest ‑ testDisposeTargetThenBinding
…

♻️ This comment has been updated with latest results.

@vogella
Migrate ConformanceTestSuite and dependencies to JUnit 5
a95e1d5 
- Migrate org.eclipse.jface.tests.databinding.conformance tests to JUnit 5.
- Update ConformanceTestSuite to use @testfactory.
- Update MANIFEST.MF to import junit.jupiter.api.function.
@vogella vogella force-pushed the migrate-jface-databinding-conformance-junit5 branch from 6b7b229 to a95e1d5 Compare January 12, 2026 09:03
@vogella vogella marked this pull request as ready for review January 12, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vogella