[Gtk4] Fix lazily populated menus being empty#3426
Merged
Conversation
The first attempt to wire submenu SHOW/HIDE listeners happens too early, at bar map time. On GTK4 those nested GtkPopoverMenu children may not be fully reachable yet, so Eclipse never receives SWT.Show for the cascade submenu and never runs menuAboutToShow() . The retry in gtk_show() runs after the parent dropdown is actually shown, when GTK has built the widget tree, so the nested submenu popovers can be found and connected
Member
Author
|
After the fix: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first attempt to wire submenu SHOW/HIDE listeners happens too early, at bar map time. On GTK4 those nested GtkPopoverMenu children may not be fully reachable yet, so Eclipse never receives SWT.Show for the cascade submenu and never runs menuAboutToShow() . The retry in gtk_show() runs after the parent dropdown is actually shown, when GTK has built the widget tree, so the nested submenu popovers can be found and connected.
Fixes #3423