Skip to content

StyledText treats shortcuts incorrectly with Japanese keyboard layout #3306#3307

Open
tmssngr wants to merge 1 commit into
eclipse-platform:masterfrom
syntevo:styledtext-keys
Open

StyledText treats shortcuts incorrectly with Japanese keyboard layout #3306#3307
tmssngr wants to merge 1 commit into
eclipse-platform:masterfrom
syntevo:styledtext-keys

Conversation

@tmssngr
Copy link
Copy Markdown
Contributor

@tmssngr tmssngr commented May 15, 2026

On MacOS 14 with "Japanese Kana" keyboard pressing Cmd+A results in event.keycode == 12385 while event.character == 'a'.

This PR fixes the problem for me.

…clipse-platform#3306

On MacOS 14 with "Japanese Kana" keyboard pressing Cmd+A results in
event.keycode == 12385 while event.character == 'a'.
@Phillipus
Copy link
Copy Markdown
Contributor

Is this a problem only on on macOS 14? That's out of date now. Is it a problem on 15.7.x and 26.x?

@github-actions
Copy link
Copy Markdown
Contributor

Test Results

  181 files   -  1    181 suites   - 1   29m 10s ⏱️ + 1m 13s
4 666 tests  - 57  4 645 ✅  - 55   20 💤  - 3  1 ❌ +1 
6 755 runs   - 57  6 594 ✅  - 55  160 💤  - 3  1 ❌ +1 

For more details on these failures, see this check.

Results for commit f7172c9. ± Comparison against base commit f33b79e.

This pull request removes 57 tests.
org.eclipse.swt.graphics.ImageWin32Tests ‑ testDisposeDrawnImageBeforeRequestingTargetForOtherZoom
org.eclipse.swt.graphics.ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[1] true
org.eclipse.swt.graphics.ImageWin32Tests ‑ testDrawImageAtDifferentZooms(boolean)[2] false
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageDataForDifferentFractionalZoomsShouldBeDifferent
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.graphics.ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[1] true
org.eclipse.swt.graphics.ImageWin32Tests ‑ testRetrieveImageDataAtDifferentZooms(boolean)[2] false
org.eclipse.swt.graphics.ImageWin32Tests ‑ test_getImageData_fromCopiedImage
org.eclipse.swt.graphics.ImageWin32Tests ‑ test_getImageData_fromImageForImageDataFromImage
org.eclipse.swt.tests.win32.Test_org_eclipse_swt_dnd_DND ‑ testByteArrayTransfer
…

@tmssngr
Copy link
Copy Markdown
Contributor Author

tmssngr commented May 15, 2026

No, this problem is reproducible with MacOS 26.5, too. I have not tried on other systems though.

Are these failing Windows tests caused by this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants