Skip to content

Restore and modernize GC.setClipping() tests #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptziegler wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −31
Open

Restore and modernize GC.setClipping() tests #3134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 16 additions & 31 deletions ...e.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_graphics_GC.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*******************************************************************************
* Copyright (c) 2000, 2016 IBM Corporation and others.
* Copyright (c) 2000, 2026 IBM Corporation and others.
*
* This program and the accompanying materials
* are made available under the terms of the Eclipse Public License 2.0
Expand All @@ -16,6 +16,7 @@

import static org.eclipse.swt.internal.DPIUtil.pointToPixel;
import static org.eclipse.swt.tests.junit.SwtTestUtil.assertSWTProblem;
import static org.junit.jupiter.api.Assertions.assertAll;
import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
Expand Down Expand Up @@ -793,40 +794,24 @@ public void test_setBackgroundLorg_eclipse_swt_graphics_Color() {

@Test
public void test_setClippingIIII() {
// intermittently fails on XP for reasons unknown, comment out the test case
// until the problem is figured out
// Canvas canvas = new Canvas(shell, SWT.BORDER);
// shell.setSize(110,110);
// canvas.setSize(100,100);
// shell.open();
// GC testGc = new GC(canvas);
// testGc.setClipping(0,5,10,20);
// Rectangle rect = testGc.getClipping();
// assertTrue(rect.x == 0);
// assertTrue(rect.y == 5);
// assertTrue(rect.width == 10);
// assertTrue(rect.height == 20);
// testGc.dispose();
// canvas.dispose();
gc.setClipping(0,5,10,20);
Rectangle rect = gc.getClipping();
assertAll(
() -> assertEquals(0,rect.x),
() -> assertEquals(5, rect.y),
() -> assertEquals(10,rect.width),
() -> assertEquals(20,rect.height));
}

@Test
public void test_setClippingLorg_eclipse_swt_graphics_Rectangle() {
// intermittently fails on XP for reasons unknown, comment out the test case
// until the problem is figured out
// Canvas canvas = new Canvas(shell, SWT.BORDER);
// shell.setSize(110,110);
// canvas.setSize(100,100);
// shell.open();
// GC testGc = new GC(canvas);
// testGc.setClipping(new Rectangle(0,5,10,20));
// Rectangle rect = testGc.getClipping();
// assertTrue(rect.x == 0);
// assertTrue(rect.y == 5);
// assertTrue(rect.width == 10);
// assertTrue(rect.height == 20);
// testGc.dispose();
// canvas.dispose();
gc.setClipping(new Rectangle(0,5,10,20));
Rectangle rect = gc.getClipping();
assertAll(
() -> assertEquals(0,rect.x),
() -> assertEquals(5, rect.y),
() -> assertEquals(10,rect.width),
() -> assertEquals(20,rect.height));
}

@Test
Expand Down
Loading