[Win32] Improve parameterization of monitor-specific scaling enablement #2980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeikoKlare
force-pushed
the
monitorspecificscaling-default-assumptions
branch
from
03be8b1 to
49eb650
Compare
Some parts of the implementation currently assume monitor-specific scaling to be disabled by default and autoscaling mode to default to "integer". With monitor-specific scaling becoming the default in the future, these assumptions will not hold anymore. In order to prepare for that, this change adapts some code to properly deal with monitor-specific scaling and autoscaling mode having arbitrary default values. # Conflicts: # bundles/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/internal/DPIUtil.java # tests/org.eclipse.swt.tests/JUnit Tests/org/eclipse/swt/tests/junit/AllNonBrowserTests_AutoscaleOsNonDefaults.java
HeikoKlare
force-pushed
the
monitorspecificscaling-default-assumptions
branch
from
49eb650 to
6c7229e
Compare
Contributor
Test Results (linux) 56 files 56 suites 4m 24s ⏱️ Results for commit 6c7229e. |
Contributor
Test Results (macos) 54 files 54 suites 7m 16s ⏱️ Results for commit 6c7229e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of the implementation currently assume monitor-specific scaling to be disabled by default and autoscaling mode to default to "integer". With monitor-specific scaling becoming the default in the future (see #2955), these assumptions will not hold anymore. In order to prepare for that, this change adapts some code to properly deal with monitor-specific scaling and autoscaling mode having arbitrary default values.