Execute tests with non-default autoscaling settings in I-Build #2967
+119
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
The SWT tests are currently executed with the default autoscaling settings during I-Builds. For Tycho test execution (e.g., in GitHub Actions runs), the configuration is modified to run in "quarter" autoscaling mode. Since multiple different autoscaling modes need to be supported (especially on Windows), the execution with just one configuration leads to a high risk of undetected regressions with other configurations. This change extends the I-Build test execution to run the test suite with OS default settings and with one relevant non-default set of settings. For Windows, this will specifically cover the monitor-specific scaling with "quarter" autoscaling and non-monitor-specific scaling with "integer" autoscaling. For Linux and MacOS, which do not support monitor-specific scaling, this reduces to testing "integer" and "quarter" modes. This is achieved by an additional, accordingly configured test suite, which is added to the test.xml to be executed in I-Builds. To keep the Tycho test execution times low (also used in GitHub Actions runs), that test suite is not added to Tycho test execution. The configuration is adapted to use the OS default settings for the Tycho runs (instead of using "quarter" mode, which is now covered by I-Build tests instead).
HeikoKlare
force-pushed
the
swt-tests-autoscale-configurations
branch
from
349d7a2 to
2d23cfa
Compare
Contributor
Author
|
Let's take today's I-Build to see if this works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SWT tests are currently executed with the default autoscaling settings during I-Builds. For Tycho test execution (e.g., in GitHub Actions runs), the configuration is modified to run in "quarter" autoscaling mode. Since multiple different autoscaling modes need to be supported (especially on Windows), the execution with just one configuration leads to a high risk of undetected regressions with other configurations.
This change extends the I-Build test execution to run the test suite with OS default settings and with one relevant non-default set of settings. For Windows, this will specifically cover the monitor-specific scaling with "quarter" autoscaling and non-monitor-specific scaling with "integer" autoscaling. For Linux and MacOS, which do not support monitor-specific scaling, this reduces to testing "integer" and "quarter" modes. This is achieved by an additional, accordingly configured test suite, which is added to the test.xml to be executed in I-Builds.
To keep the Tycho test execution times low (also used in GitHub Actions runs), that test suite is not added to Tycho test execution. The configuration is adapted to use the OS default settings for the Tycho runs (instead of using "quarter" mode, which is now covered by I-Build tests instead).
This becomes particularly useful when changing the Windows default for autoscaling in SWT to monitor-specific scaling, as it will ensure regression testing with the pre-existing default autoscaling settings: