Fix wrong usage of getImageData and Permanent ImageHandle creation #2964
+30
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeikoKlare
reviewed
Jan 14, 2026
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
amartya4256/fix_image_get_imageData_usage
branch
from
6dfd395 to
080bf7f
Compare
HeikoKlare
reviewed
Jan 14, 2026
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Show resolved
Hide resolved
amartya4256
force-pushed
the
amartya4256/fix_image_get_imageData_usage
branch
from
080bf7f to
b434fac
Compare
HeikoKlare
force-pushed
the
amartya4256/fix_image_get_imageData_usage
branch
from
b434fac to
160ceb3
Compare
There are many places in several ImageProviders where we want to create a new ImageHandle or ImageData and use getImageData or create permanent ImageHandle to obtain just ImageData respectively. This commit replaces such usage with directly calling newImageData instead of getImageData and creating a temporary ImageHandle when calling newImageData.
HeikoKlare
force-pushed
the
amartya4256/fix_image_get_imageData_usage
branch
from
160ceb3 to
9d46b3b
Compare
HeikoKlare
approved these changes
Jan 14, 2026
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The change is sound and I did not find any regression when testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many places in several ImageProviders where we want to create a new ImageHandle or ImageData and use getImageData or create permanent ImageHandle to obtain just ImageData respectively. This PR replaces such usage with directly calling newImageData instead of getImageData and creating a temporary ImageHandle when calling newImageData.
Needed for #2905