Add tests for GatherUnusedDependenciesOperation#2156
Closed
vogella wants to merge 1 commit intoeclipse-pde:masterfrom
Closed
Add tests for GatherUnusedDependenciesOperation#2156vogella wants to merge 1 commit intoeclipse-pde:masterfrom
vogella wants to merge 1 commit intoeclipse-pde:masterfrom
Conversation
This commit adds a new test class `GatherUnusedDependenciesOperationTest` to verify the behavior of `GatherUnusedDependenciesOperation`. It includes tests for: - Identifying unused dependencies. - Ensuring used dependencies are not reported. - Handling of mandatory dependencies that are also re-exported by optional dependencies. The new test is registered in `AllPDETests`. If the ignored test is enabled you also have an example for eclipse-pde#2115
e15515b to
79d8945
Compare
Test Results 330 files - 441 330 suites - 441 40m 0s ⏱️ - 15m 58s For more details on these failures, see this check. Results for commit 79d8945. ± Comparison against base commit abc3cc7. This pull request removes 2665 and adds 3 tests. Note that renamed tests count towards both. |
Contributor
|
I would strongly recommend not creating test classes / bundles "inline" as it bloats the test (what makes it hard to read) and is harder to analyze (e.g. no real project structure to look at in the IDE only temporary java/class files). It would be better to have a set of bundles that is then used in the test and can be imported for example in a workspace to see the problem in action. |
laeubi
reviewed
Dec 17, 2025
| } | ||
| } | ||
| } | ||
| Assert.assertFalse("Should NOT remove mandatory BundleB even if optional BundleA re-exports it", found); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a new test class
GatherUnusedDependenciesOperationTestto verify the behavior of
GatherUnusedDependenciesOperation. It includes tests for:The new test is registered in
AllPDETests.If the ignored test is enabled you also have an example for #2115