Skip to content

JDT Clean-up Use String.replace() instead of String.replaceAll()#2155

Merged
vogella merged 2 commits intoeclipse-pde:masterfrom
vogella:string_replace_cleanup
Jan 20, 2026
Merged

JDT Clean-up Use String.replace() instead of String.replaceAll()#2155
vogella merged 2 commits intoeclipse-pde:masterfrom
vogella:string_replace_cleanup

Conversation

@vogella
Copy link
Copy Markdown
Contributor

@vogella vogella commented Dec 12, 2025

Testing this clean-up to enable it by default via
eclipse-platform/eclipse.platform.ui#3517

@vogella
Copy link
Copy Markdown
Contributor Author

vogella commented Dec 12, 2025

LGTM, lets see what CI thinks

@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 0994ff79cb23fed4973f591644a1f91c83c77987 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Fri, 12 Dec 2025 09:01:48 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
index 00ad9d5c91..dd5926f656 100644
--- a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: Generic UI components related to BND
 Bundle-SymbolicName: org.eclipse.pde.bnd.ui;singleton:=true
 Bundle-Vendor: Eclipse.org
-Bundle-Version: 1.2.400.qualifier
+Bundle-Version: 1.2.500.qualifier
 Bundle-Localization: plugin
 Export-Package: org.eclipse.pde.bnd.ui.autocomplete;version="1.0.0";x-friends:="org.eclipse.pde.ui",
  org.eclipse.pde.bnd.ui.plugins;x-internal:=true,
diff --git a/ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF
index b4cb32ba28..792df054fd 100644
--- a/ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.spy.event/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.spy.event;singleton:=true
-Bundle-Version: 1.2.200.qualifier
+Bundle-Version: 1.2.300.qualifier
 Bundle-Vendor: Eclipse Foundation
 Require-Bundle: org.eclipse.ui,
  org.eclipse.core.runtime,
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 12, 2025

Test Results

   798 files  ±0     798 suites  ±0   1h 4m 49s ⏱️ + 2m 50s
 3 732 tests ±0   3 596 ✅ ±0  136 💤 ±0  0 ❌ ±0 
11 127 runs  ±0  10 718 ✅ ±0  409 💤 ±0  0 ❌ ±0 

Results for commit da58e5e. ± Comparison against base commit 3351cdb.

♻️ This comment has been updated with latest results.

@vogella vogella force-pushed the string_replace_cleanup branch from e081ba3 to 7d2d1d3 Compare December 16, 2025 16:57
@vogella vogella force-pushed the string_replace_cleanup branch from 7d2d1d3 to 1515b12 Compare January 19, 2026 09:24
@vogella vogella force-pushed the string_replace_cleanup branch from 1515b12 to da58e5e Compare January 20, 2026 08:03
@vogella vogella merged commit 2c1ab28 into eclipse-pde:master Jan 20, 2026
23 of 24 checks passed
@vogella vogella deleted the string_replace_cleanup branch January 20, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants