Decouple OpcUaSubscription.SyncState from MonitoredItem operations#1726
Open
kevinherron wants to merge 5 commits intomainfrom
Open
Decouple OpcUaSubscription.SyncState from MonitoredItem operations#1726kevinherron wants to merge 5 commits intomainfrom
kevinherron wants to merge 5 commits intomainfrom
Conversation
SyncState now tracks only subscription settings synchronization. MonitoredItem add/remove no longer sets UNSYNCHRONIZED, and create() always sets SYNCHRONIZED. New isMonitoredItemsSynchronized() and isFullySynchronized() methods provide item-level and aggregate sync checks.
Contributor
There was a problem hiding this comment.
Pull request overview
Decouples OpcUaSubscription.SyncState from MonitoredItem add/remove operations so subscription sync reflects only subscription-parameter synchronization, while introducing explicit APIs to check MonitoredItem-level and aggregate synchronization state.
Changes:
OpcUaSubscription#create()now always setsSyncState.SYNCHRONIZED, and add/remove MonitoredItem operations no longer flip subscription sync state.- Add
isMonitoredItemsSynchronized()andisFullySynchronized()for item-level and aggregate synchronization checks. - Add integration tests validating the new semantics and new synchronization helpers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
opc-ua-sdk/sdk-client/src/main/java/org/eclipse/milo/opcua/sdk/client/subscriptions/OpcUaSubscription.java |
Updates subscription sync-state behavior and adds new synchronization query APIs. |
opc-ua-sdk/integration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/subscriptions/OpcUaSubscriptionTest.java |
Adds tests covering the new sync semantics and helper methods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…/client/subscriptions/OpcUaSubscription.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot run |
Contributor
|
@kevinherron I've opened a new pull request, #1728, to work on those changes. Once the pull request is ready, I'll request review from you. |
Agent-Logs-Url: https://github.com/eclipse-milo/milo/sessions/4fcae70e-900d-48d9-9c6e-9ca4567ac16f Co-authored-by: kevinherron <340273+kevinherron@users.noreply.github.com>
Decouple subscription sync-state from monitored item sync + add aggregate sync checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SyncState now tracks only subscription settings synchronization. MonitoredItem add/remove no longer sets UNSYNCHRONIZED, and create() always sets SYNCHRONIZED. New isMonitoredItemsSynchronized() and isFullySynchronized() methods provide item-level and aggregate sync checks.