Allow RUNNING -> WAIT_FOR_CONFIRMATION via DDI 'denied' feedback - #3238
Open
herdt-michael wants to merge 1 commit into
Open
Allow RUNNING -> WAIT_FOR_CONFIRMATION via DDI 'denied' feedback#3238herdt-michael wants to merge 1 commit into
herdt-michael wants to merge 1 commit into
Conversation
Extend the confirmation flow so a device can revoke a previously granted
consent (auto- or manually confirmed) for an action that has not been
installed yet, by sending 'confirmation: "denied"' to the existing
confirmationBase/{actionId}/feedback endpoint.
- Relax denyAction guard so a 'denied' feedback is accepted for any active
action, not only while WAIT_FOR_CONFIRMATION. An already-confirmed active
action reverts to WAIT_FOR_CONFIRMATION with no maintenance-window or
progress gating.
- Record a distinct ActionStatus audit-trail message for the revocation,
separate from a first-time deny.
- No new DDI endpoint or management API method is introduced.
Tests cover deny after auto-confirm, deny after manual confirm, subsequent
base-resource poll offering confirmationBase again, and re-confirmation
returning to RUNNING.
Fixes eclipse-hawkbit#3220
Signed-off-by: Jeroen Laverman <jeroen.laverman@bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the confirmation flow so a device can revoke a previously granted consent (auto- or manually confirmed) for an action that has not been installed yet, by sending 'confirmation: "denied"' to the existing confirmationBase/{actionId}/feedback endpoint.
Tests cover deny after auto-confirm, deny after manual confirm, subsequent base-resource poll offering confirmationBase again, and re-confirmation returning to RUNNING.
Fixes #3220