perf(tests): one BPMN editor journey; the full new-file sweep leaves the PR gate - #6709
Merged
Conversation
…the PR gate Two consolidations in the ui/smoke IT set: BpmnEditorIT, BpmnEditorLoadsIT and BpmnEditorPropertyPopupIT each paid a Dirigible boot, a browser and ~30s of editor bring-up to look at the same freshly created .bpmn file - three sequential stations of one user journey. They are now ONE editor session in BpmnEditorIT (boot assertions -> property-popup lifecycle -> rename + save + published), keeping every assertion of all three classes. Measured: 59s for the merged journey vs ~200s of CI time for the three classes. CreateNewFileIT (the full 20-option sweep - every option opens its own editor, making it the single longest IT at 431s on CI) was tagged smoke, so every PR paid for it. The PR gate now runs the new CreateNewFileSmokeIT - one representative option per heavyweight editor family (Monaco, BPMN modeler, EDM modeler, form builder), 59s locally vs 187s for the sweep - while the exhaustive sweep keeps running nightly/master in the ui shard. (Closing each editor tab between options was tried first and measured: 183.8s vs 186.9s baseline - the cost is the per-editor bring-up itself, not iframe accumulation, so the sweep stays as-is.) CLAUDE_BPMN.md / CLAUDE_UI.md updated for the merged class. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two consolidations in the
ui/smoke IT set — the third installment of the IT-speed effort (#6702 sharding, #6703/#6708 boot-per-class):1. The three BPMN editor ITs become one editor session.
BpmnEditorLoadsIT,BpmnEditorPropertyPopupITandBpmnEditorITeach paid a Dirigible boot, a browser and ~30s of Oryx editor bring-up to look at the same freshly created.bpmnfile — three sequential stations of one user journey.BpmnEditorITnow asserts all three in order (editor boot → property-popup lifecycle → rename + save + "Published"), keeping every assertion of all three classes. Measured: 59s for the merged journey vs ~200s of CI time for the three classes.2. The exhaustive new-file sweep leaves the per-PR smoke gate.
CreateNewFileITloops all 20NewFileOptions, each opening its own editor — the single longest IT (431s on CI) — and was taggedsmoke, so every PR paid for it. The PR gate now runs the newCreateNewFileSmokeIT: one representative option per heavyweight editor family (Monaco/TypeScript, BPMN modeler, EDM modeler, form builder), 59s locally vs 187s for the sweep. The full sweep keeps running on master + nightly in theuishard, so no coverage is lost — it just stops taxing every PR.Honesty note: closing each editor tab between options was tried first and measured — 183.8s vs 186.9s baseline, i.e. no effect (the cost is the per-editor bring-up itself, not iframe accumulation) — so that change was discarded and the sweep body stays untouched.
CLAUDE_BPMN.md/CLAUDE_UI.mdupdated for the merged class.Impact
uishard (master/nightly): ~2.5 min less (two fewer boots + editor bring-ups).Verification
BpmnEditorIT: green, 58.65s (isolated Maven repo, fresh state).CreateNewFileSmokeIT: green, 58.63s.CreateNewFileIT(untouched body, tag removed): green in the same setup earlier (186.9s baseline run).mvn formatter:validategreen.🤖 Generated with Claude Code