Upgraded Monaco editor#6025
Open
StanZGenchev wants to merge 1 commit into
Open
Conversation
…g, drop removed createDiffNavigator and editor.main.nls.js link) Signed-off-by: StanZGenchev <stan.genchev@codbex.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade the bundled Monaco editor from 0.40.0 to 0.55.1 (~2.5 years of upstream fixes, security patches, and the new default diff editor).
Monaco moved the language namespaces outside the
languageobject, so we had to do a lot of changes like this -monaco.languages.typescript.*->monaco.typescript.*.createDiffNavigatoras it was removed upstream.createDiffEditoroptions.Took advantage of the more advanced diff algorithm in the newer version. Also enabled whitespace changes as previously they were not being rendered.
editor.main.nls.jslink is removed.The English-NLS module got removed as Monaco inlined the default English strings directly into
editor.main.js. Might want to look into locale support in the future if we introduce a second language for the IDE part of Dirigible.What issues does this PR fix or reference?
#6024