Fixed StartWorkspaceUsingVSCodeDesktopSshEditor test case due to new landing page

[olkornii]

What does this PR do?

Added check and unselect for 'UseExtension' switcher.

What issues does this PR fix or reference?

Fix for https://redhat.atlassian.net/browse/CRW-10830

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix or new feature
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

[dmytro-ndp]

Review Summary

The intent of this PR is good — it adapts the test to a new landing page layout by updating XPath locators, removing dead code, and adding logic to toggle the "UseExtension" switcher. However, there are several issues with the implementation that should be addressed before merging.

1. checkElementExistsByXpath should use waitVisibilityBoolean instead of waitVisibility

DriverHelper already provides waitVisibilityBoolean() — a purpose-built method that returns true/false with configurable attempts and polling. The new checkElementExistsByXpath reimplements this with a try/catch around waitVisibility, which:

• Uses the default timeout (TS_SELENIUM_CLICK_ON_VISIBLE_ITEM) which may be too long for a conditional check — you want a quick probe, not a full wait.
• Swallows all exceptions (not just TimeoutError), so network failures, session errors, etc. silently return false.

Suggested fix:

async checkElementExistsByXpath(xpath: string): Promise<boolean> {
    Logger.debug();
    return await this.driverHelper.waitVisibilityBoolean(By.xpath(xpath), 3, 3000);
}

2. Logger.debug() usage doesn't follow code style

Per CODE_STYLE.md, public methods should use Logger.debug() with no arguments — it auto-logs the class and method name. The PR passes string arguments instead:

Logger.debug('Click on xPath: ' + xpath);  // ❌
Logger.debug('Check if element exists');    // ❌
Logger.debug();                             // ✅

3. Consider whether generic XPath helpers belong in WorkspaceHandlingTests

clickOnElementByXpath(xpath) is a thin wrapper around this.driverHelper.waitAndClick(By.xpath(xpath)). And checkElementExistsByXpath wraps waitVisibilityBoolean. Adding generic element-interaction methods to a test-library class that's shared across all specs moves it toward becoming a second DriverHelper.

Consider either:

• Keeping the toggle logic inline in the spec file (since it's specific to this test's landing page), or
• If these helpers are genuinely reusable, placing the toggle handling in a dedicated page object for the SSH landing page.

4. Minor: XPath locator //div[@class="toggle-input"] is fragile

//div[@class="toggle-input"] matches any toggle on the page by class alone. If the page ever gets a second toggle, this will break silently. A more specific selector (e.g., using a parent container or label text) would be more resilient.

---

The dead code removal (unused imports, KubernetesCommandLineToolsExecutor, etc.) and the updated titlexPath locator are both good changes.

[dmytro-ndp]

PR looks good to merge.

Thank you for the test update, @olkornii !