Skip to content

Forward tree search text to extension backend#7

Merged
jreineckearm merged 3 commits intoeclipse-cdt-cloud:mainfrom
phongtrinh1234:tree-backend-search-support
Mar 16, 2026
Merged

Forward tree search text to extension backend#7
jreineckearm merged 3 commits intoeclipse-cdt-cloud:mainfrom
phongtrinh1234:tree-backend-search-support

Conversation

@phongtrinh1234
Copy link
Copy Markdown
Contributor

@phongtrinh1234 phongtrinh1234 commented Mar 5, 2026

This PR exposes search text updates from the CDTTree search feature
via vscode-messenger.

This is required to support backend search in the Peripheral Inspector
to address performance issues with large SVD files.

Related to:
eclipse-cdt-cloud/vscode-peripheral-inspector#71

@jreineckearm
Copy link
Copy Markdown
Contributor

jreineckearm commented Mar 5, 2026

Thanks for your contribution, @phongtrinh1234 .
To be able to accept your contribution, you have to create an Eclipse account and digitally sign the ECA.
Same check happens for your related PR eclipse-cdt-cloud/vscode-peripheral-inspector#75.

@jreineckearm jreineckearm mentioned this pull request Mar 5, 2026
Merged
@phongtrinh1234 phongtrinh1234 force-pushed the tree-backend-search-support branch from 58e086e to 7ecbcb0 Compare March 5, 2026 09:26
jreineckearm
jreineckearm reviewed Mar 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot for these changes. Just one nit from code review.

Not tested yet in combination with eclipse-cdt-cloud/vscode-peripheral-inspector#75 Will approve once I had a chance to do so.

Comment thread src/tree/vscode/tree-webview-view-provider.ts Outdated
@jreineckearm
Copy link
Copy Markdown
Contributor

jreineckearm commented Mar 16, 2026

@phongtrinh1234 , please do NOT rebase this PR to main for the time being. I updated dependencies and merged that change to main already. But it turns out that the vscode-messenger parts are not backwards compatible and cause trouble with the not yet updated vscode-peripheral-inspector. Please wait until I created the matching updates there (on it as I write this).

@jreineckearm
Copy link
Copy Markdown
Contributor

jreineckearm commented Mar 16, 2026

Reverted the offending changes on main, should be OK again to rebase/merge.

@phongtrinh1234
tree: forward searchChanged event to extension backend
0a07bc3 
Expose search text updates through vscode-messenger so extensions
can implement backend search for large trees.

Also document the new onDidSearchChanged event in the tree README.
@phongtrinh1234
Rename onDidSearchChanged to onDidSearchChange
4155a34
@phongtrinh1234
Add backend search configuration and increase search debounce
ddd3117
@phongtrinh1234 phongtrinh1234 force-pushed the tree-backend-search-support branch from 7956836 to ddd3117 Compare March 16, 2026 09:35
jreineckearm
jreineckearm approved these changes Mar 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phongtrinh1234 ! Changes look good to me. Tested in combination with eclipse-cdt-cloud/vscode-peripheral-inspector#75

@jreineckearm jreineckearm merged commit b571797 into eclipse-cdt-cloud:main Mar 16, 2026
3 checks passed
@jreineckearm
Copy link
Copy Markdown
Contributor

jreineckearm commented Mar 16, 2026

Congratulations on your first merged PR on eclipse-cdt-cloud, @phongtrinh1234 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreineckearm jreineckearm jreineckearm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phongtrinh1234 @jreineckearm