Enable creation of custom bot username - #77
Open
pstankie wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables specifying a non-default GitHub bot username during bot setup, intended to allow switching to an alternate bot account when the usual one is suspended.
Changes:
- Add an optional bot-username parameter to the GitHub bot setup flow and propagate it into Playwright automation scripts.
- Adjust signup-page loading behavior to attempt continuation when the initial HTTP response is non-OK.
- Document the custom bot-username usage in README.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds an example for running setup-bot with a custom bot username. |
| github/setup_github_bot.sh | Accepts an optional bot username and passes it to credential creation + signup flow. |
| github/playwright/gh_signup.py | Accepts optional bot username and tweaks signup-page load handling. |
| github/playwright/gh_login.py | Accepts optional bot username for login automation. |
| github/playwright/gh_create_renovate_token.py | Accepts optional bot username for token automation. |
| github/playwright/gh_create_otterdog_token.py | Accepts optional bot username for token automation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
44
to
48
| create_github_credentials() { | ||
| echo "# Creating GitHub bot user credentials..." | ||
| "${CI_ADMIN_ROOT}/pass/add_creds.sh" "github" "${PROJECT_NAME}" || true | ||
| "${CI_ADMIN_ROOT}/pass/add_creds.sh" "github_ssh" "${PROJECT_NAME}" || true | ||
| "${CI_ADMIN_ROOT}/pass/add_creds.sh" "github" "${PROJECT_NAME}" "${BOT_USERNAME}" || true | ||
| "${CI_ADMIN_ROOT}/pass/add_creds.sh" "github_ssh" "${PROJECT_NAME}" "${BOT_USERNAME}" || true | ||
| } |
Comment on lines
+119
to
+120
| # Setup GitHub bot with a custom bot username (default: eclipse-cbi-bot) | ||
| ci-adm github setup-bot technology.cbi eclipse-cbi2-bot |
Comment on lines
+20
to
+23
| try: | ||
| expect(page.locator('#email')).to_be_visible(timeout=10000) | ||
| except Exception: | ||
| raise RuntimeError(f"unable to load signup page: status={response.status}, url={page.url}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes Github suspends bot user and isn't rushing to unsuspend it for several weeks.
This modification allows specification for another bot username.