Fix load_directory silently dropping all descriptors#545
Merged
s-heppner merged 4 commits intoMay 14, 2026
Conversation
s-heppner
requested changes
May 13, 2026
s-heppner
requested changes
May 13, 2026
s-heppner
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #544
Problem
load_directory()calledread_server_aas_json_file_into(), which internally only adds items whereisinstance(item, model.Identifiable).AssetAdministrationShellDescriptorandSubmodelDescriptorare notIdentifiable, so all descriptors were silently skipped. The registry always started empty.Fix
Parse descriptor JSON directly with
ServerAASFromJsonDecoderand add items toDictDescriptorStorevia anisinstance(item, Descriptor)check.