Skip to content

Fix load_directory silently dropping all descriptors#545

Merged
s-heppner merged 4 commits into
developfrom
fix/load-directory-descriptor-not-identifiable
May 14, 2026
Merged

Fix load_directory silently dropping all descriptors#545
s-heppner merged 4 commits into
developfrom
fix/load-directory-descriptor-not-identifiable

Conversation

@zrgt
Copy link
Copy Markdown
Contributor

@zrgt zrgt commented May 12, 2026

Fixes #544

Problem

load_directory() called read_server_aas_json_file_into(), which internally only adds items where isinstance(item, model.Identifiable). AssetAdministrationShellDescriptor and SubmodelDescriptor are not Identifiable, so all descriptors were silently skipped. The registry always started empty.

Fix

Parse descriptor JSON directly with ServerAASFromJsonDecoder and add items to DictDescriptorStore via an isinstance(item, Descriptor) check.

Comment thread server/app/model/provider.py Outdated
Comment thread server/app/model/provider.py Outdated
Comment thread server/app/model/provider.py
@zrgt zrgt requested a review from s-heppner May 13, 2026 20:07
@s-heppner s-heppner merged commit 34a6d6f into develop May 14, 2026
25 checks passed
@s-heppner s-heppner deleted the fix/load-directory-descriptor-not-identifiable branch May 14, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants