Fix OrderedNamespaceSet.__setitem__ int: remove-before-add#517
Open
zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
Open
Fix OrderedNamespaceSet.__setitem__ int: remove-before-add#517zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
Conversation
…ng new add-before-remove caused false AASConstraintViolation when new item shares an attribute (e.g. id_short) with the item being replaced. Fix removes old item first, rolls back if the subsequent add fails. Fixes eclipse-basyx#498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderedNamespaceSet.__setitem__with an integer index calledsuper().add(new_item)before removing the old item. When the new item shares an attribute (e.g.id_short) with the item being replaced,_validate_namespace_constraintsraised a falseAASConstraintViolationbecause the old item was still in the backend.Fix: remove the old item first, attempt the add, and restore the old item on failure.
Fixes #498
Test plan
test_ordered_namespaceset_int_setitem_same_id_short— replace item with new one sharing sameid_shortsucceeds without errortest.model.test_basesuite passes