Fix OrderedNamespaceSet.__setitem__ slice assigns exhausted iterator#516
Open
zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
Open
Fix OrderedNamespaceSet.__setitem__ slice assigns exhausted iterator#516zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
Conversation
slice branch stored exhausted islice iterator back into _order instead of the materialized successful_new_items list, resulting in an empty slice assignment that discarded all newly added items. Fixes eclipse-basyx#494
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
OrderedNamespaceSet.__setitem__slice branch, the code stored the exhaustedisliceiterator back intoself._order[s]instead of the already-materializedsuccessful_new_itemslist. Python evaluates the iterator during slice assignment, gets nothing (already consumed), so all new items were silently dropped from the ordering while still being present in the NamespaceSet backends — leaving the set in an inconsistent state.Fix:
self._order[s] = successful_new_items.Fixes #494
Test plan
test_ordered_namespaceset_slice_setitem_preserves_order— replace 2-item slice, verify new items appear in correct positionstest.model.test_basesuite passes