Fix NamespaceSet.clear() fires del-hook once per item not per backend#515
Open
zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
Open
Fix NamespaceSet.clear() fires del-hook once per item not per backend#515zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
Conversation
clear() iterated all backends firing _execute_item_del_hook for each, resulting in N*M calls (N items, M backends) instead of N. Fix collects items from first backend only before firing hooks. Fixes eclipse-basyx#497
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NamespaceSet.clear()iterated all backends and called_execute_item_del_hookfor each item in each backend. With M backends and N items this fired M×N hook calls instead of N.Fix collects items from first backend only, fires hook once per item, then clears all backends.
Fixes #497
Test plan
test_namespaceset_clear_hook_called_once_per_item— 2 items + 2 backends → exactly 2 hook callstest.model.test_basesuite passes (53 tests)