Fix LocalFileIdentifiableStore.__len__ to count only .json store files#507
Open
zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
Open
Fix LocalFileIdentifiableStore.__len__ to count only .json store files#507zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
zrgt wants to merge 1 commit intoeclipse-basyx:developfrom
Conversation
s-heppner
requested changes
May 6, 2026
| """ | ||
| logger.debug("Fetching number of documents from database ...") | ||
| return len(os.listdir(self.directory_path)) | ||
| return sum(1 for f in os.listdir(self.directory_path) if f.endswith(".json")) |
Member
There was a problem hiding this comment.
That's not enough though is it? In theory it could also be ".JSON". Of course only when added manually and not by our code.
However, if we ever decide to add objects to the store as .JSON files, this will fail silently.
Member
|
Actually: Instead of adding support for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #503
Changes
__len__now counts only.jsonfiles in the store directory, ignoring hidden files (.DS_Store), temp files, and subdirectoriestest_len_ignores_non_json_filesunit test