chore: Ci/GitHub actions#1
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The CJS build require()d pure-ESM deps (unified, remark-*, rehype-*). Under
Node >=20.19 / >=22 (require(ESM) enabled, as in CI), esbuild interop returned
the module namespace { default: fn } instead of the default export, so
unified().use() threw 'Expected usable value but received an empty preset' and
the Docusaurus e2e build failed. Passed locally only because older Node could
not require() the ESM deps and fell back to the ESM build.
Drop the cjs tsup format and the require export condition (default now points at
the ESM build). Add test/packaging.test.ts to guard against reintroducing a CJS
build. Verified the e2e passes both with and without --experimental-require-module.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Docusaurus 3 (@docusaurus/core) requires Node >=20, so the e2e build cannot run on Node 18 (verified in a node:18 container: unit tests pass but docusaurus build fails). Update the CI matrix to [20, 22, 24], add engines.node >=20, and refresh the Node version references in the docs. Verified the full suite (incl. e2e) on Node 24 in a container. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nvm preloaded with Node 20/22/24 (default 20); switch with e.g. `nvm use 22`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.