Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1242,6 +1242,9 @@ public <T> int deletePermanent(SpiQuery<T> query) {
}

private <T> int delete(SpiQuery<T> query, boolean permanent) {
if (query.getId() != null && query.whereExpressions() == null && query.descriptor().isSoftDelete()) {
return executeInTrans((txn) -> persister.delete(query.getBeanType(), query.getId(), txn, permanent), query.transaction());
}
SpiOrmQueryRequest<T> request = createQueryRequest(Type.DELETE, query);
try {
request.initTransIfRequired();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,35 @@ public void deleteById_when_softDelete() {
cover.deletePermanent();
}

@Test
public void queryByIdDelete_when_softDelete() {

Cover cover = new Cover("q1");
cover.save();

LoggedSql.start();

DB.find(Cover.class).setId(cover.getId()).delete();

List<String> sql = LoggedSql.stop();
assertThat(sql).hasSize(1);
if (isPlatformBooleanNative()) {
assertSql(sql.get(0)).contains("update cover set deleted=true where id = ?");
} else {
assertSql(sql.get(0)).contains("update cover set deleted=1 where id = ?");
}

assertNull(DB.find(Cover.class, cover.getId()));
Cover softDeleted = DB.find(Cover.class)
.setIncludeSoftDeletes()
.setId(cover.getId())
.findOne();
assertNotNull(softDeleted);
assertThat(softDeleted.isDeleted()).isTrue();

cover.deletePermanent();
}

@Test
public void deletePermanentById_when_softDelete() {

Expand Down
Loading