Skip to content

open telemetry: Use Span.current().isRecording() rather than isValid()#3772

Merged
rob-bygrave merged 3 commits into
masterfrom
feature/otel-isRecording
May 14, 2026
Merged

open telemetry: Use Span.current().isRecording() rather than isValid()#3772
rob-bygrave merged 3 commits into
masterfrom
feature/otel-isRecording

Conversation

@rob-bygrave
Copy link
Copy Markdown
Contributor

@rob-bygrave rob-bygrave commented May 14, 2026

Change to use isRecording() to determine if ProfileStream should be created for collecting profiling events

- ebean.version 17.2.0 -> 17.5.0 (minimum for TestEntityBuilder)
- avaje-inject 11.5 -> 12.5
- Add io.avaje:junit:1.8 bundle to test dependencies
- Remove .skipDataSourceCheck(true) from database config example
- Add note about Configuration DI wiring in Step 3
- Suggest TestEntityBuilder for test data creation
- Link to testing-with-testentitybuilder.md
Change to use isRecording() to determine if ProfileStream should be
created for collecting profiling events
@rob-bygrave rob-bygrave changed the title Feature/otel is recording open telemetry: Use Span.current().isRecording() rather than isValid() May 14, 2026
@rob-bygrave rob-bygrave self-assigned this May 14, 2026
@rob-bygrave rob-bygrave added this to the 16.7.0 milestone May 14, 2026
@rob-bygrave rob-bygrave merged commit 20d7af6 into master May 14, 2026
1 check passed
@rob-bygrave rob-bygrave deleted the feature/otel-isRecording branch May 14, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant