Skip to content

added chi^2 value and success flag to fit results #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rozyczko merged 4 commits into from
Jun 17, 2025
Merged

added chi^2 value and success flag to fit results #244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1293c3f
added chi^2 value and success flag to fit results
rozyczko Jun 17, 2025
cd68acf
try being explicit wrt bumps version, so the prerelease doesn't get
rozyczko Jun 17, 2025
c8ef773
back to 1.0b7
rozyczko Jun 17, 2025
099998b
explicitly the working 1.0.0b7
rozyczko Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/easyreflectometry/fitting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ def fit(self, data: sc.DataGroup, id: int = 0) -> sc.DataGroup:
new_data['coords'][f'z_{id}'] = sc.array(
dims=[f'z_{id}'], values=sld_profile[0], unit=(1 / new_data['coords'][f'Qz_{id}'].unit).unit
)
new_data['reduced_chi'] = float(result[i].reduced_chi)
new_data['success'] = result[i].success
return new_data

def fit_single_data_set_1d(self, data: DataSet1D) -> FitResults:
Expand Down
2 changes: 2 additions & 0 deletions tests/test_fitting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,5 @@ def test_fitting(minimizer):
analysed = fitter.fit(data)
assert 'R_0_model' in analysed.keys()
assert 'SLD_0' in analysed.keys()
assert 'success' in analysed.keys()
assert analysed['success']
Loading