Accept single Experiment in Fitter.fit()#140
Merged
AndrewSazonov merged 5 commits intodevelopfrom Apr 2, 2026
Merged
Conversation
Member
AndrewSazonov
commented
Apr 2, 2026
- Refactor Fitter.fit() and _residual_function() to accept a plain list of ExperimentBase objects instead of requiring an Experiments collection.
- Remove the dummy Experiments wrapper and the object.setattr hack in Analysis.fit() single-mode loop.
- Update _residual_function to iterate over the list directly. Update all callers (single-fit, joint-fit).
- Update unit and integration tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #140 +/- ##
===========================================
- Coverage 82.26% 81.77% -0.49%
===========================================
Files 88 133 +45
Lines 5451 6868 +1417
Branches 454 573 +119
===========================================
+ Hits 4484 5616 +1132
- Misses 802 1047 +245
- Partials 165 205 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.