Skip to content

Accept single Experiment in Fitter.fit()#140

Merged
AndrewSazonov merged 5 commits intodevelopfrom
dummy-experiments-wrapper
Apr 2, 2026
Merged

Accept single Experiment in Fitter.fit()#140
AndrewSazonov merged 5 commits intodevelopfrom
dummy-experiments-wrapper

Conversation

@AndrewSazonov
Copy link
Copy Markdown
Member

  • Refactor Fitter.fit() and _residual_function() to accept a plain list of ExperimentBase objects instead of requiring an Experiments collection.
  • Remove the dummy Experiments wrapper and the object.setattr hack in Analysis.fit() single-mode loop.
  • Update _residual_function to iterate over the list directly. Update all callers (single-fit, joint-fit).
  • Update unit and integration tests.

@AndrewSazonov AndrewSazonov added the [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) label Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.77%. Comparing base (883c384) to head (0e42f9f).
⚠️ Report is 37 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #140      +/-   ##
===========================================
- Coverage    82.26%   81.77%   -0.49%     
===========================================
  Files           88      133      +45     
  Lines         5451     6868    +1417     
  Branches       454      573     +119     
===========================================
+ Hits          4484     5616    +1132     
- Misses         802     1047     +245     
- Partials       165      205      +40     
Flag Coverage Δ
integration 68.15% <88.88%> (-1.80%) ⬇️
unittests 71.27% <55.55%> (-1.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndrewSazonov AndrewSazonov merged commit 2ab2f04 into develop Apr 2, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant