Skip to content

Restructure datablocks, unify factory system, and standardize switchable-category API #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndrewSazonov merged 105 commits into from
Mar 25, 2026

Update tutorial names and copyright year [ci skip]

d575226
Select commit
Loading
Failed to load commit list.
Merged

Restructure datablocks, unify factory system, and standardize switchable-category API #128

Update tutorial names and copyright year [ci skip]
d575226
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor succeeded Mar 25, 2026 in 2s

55 issues fixed. 53 issues found.

Annotations

Check notice on line 165 in src/easydiffraction/datablocks/experiment/item/factory.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/item/factory.py#L165 

Unresolved comment '# TODO: add minimal default configuration for missing parameters'. (C100)

Check notice on line 377 in src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py#L377 

Unresolved comment '# TODO: The following is a temporary workaround to handle zero'. (C100)

Check notice on line 121 in src/easydiffraction/datablocks/experiment/collection.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/collection.py#L121 

Unresolved comment '# TODO: Move to DatablockCollection?' (C100)

Check notice on line 41 in src/easydiffraction/datablocks/experiment/categories/data/bragg_sc.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/data/bragg_sc.py#L41 

Unresolved comment '# TODO: the following pattern is valid for dict key'. (C100)

Check notice on line 108 in src/easydiffraction/datablocks/experiment/item/factory.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/item/factory.py#L108 

Unresolved comment '# TODO: @typechecked fails to find gemmi?' (C100)

Check notice on line 40 in src/easydiffraction/datablocks/structure/item/factory.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/structure/item/factory.py#L40 

Unresolved comment '# TODO: @typechecked fails to find gemmi?' (C100)

Check notice on line 90 in src/easydiffraction/datablocks/experiment/item/enums.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/item/enums.py#L90 

Unresolved comment '# TODO: Can the same be reused for other enums in this file?' (C100)

Check notice on line 168 in src/easydiffraction/datablocks/structure/categories/atom_sites/default.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/structure/categories/atom_sites/default.py#L168 

Unresolved comment '# TODO: What to pass as default?' (C100)

Check notice on line 438 in src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py#L438 

Unresolved comment '# TODO: split into multiple methods'. (C100)

Check notice on line 27 in src/easydiffraction/datablocks/experiment/collection.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/collection.py#L27 

Unresolved comment '# TODO: Make abstract in DatablockCollection?' (C100)

Check notice on line 35 in src/easydiffraction/datablocks/experiment/categories/excluded_regions/default.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/excluded_regions/default.py#L35 

Unresolved comment '# TODO: Add point_id as for the background'. (C100)

Check notice on line 303 in src/easydiffraction/datablocks/experiment/categories/data/total_pd.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/data/total_pd.py#L303 

Unresolved comment '# TODO: split into multiple methods'. (C100)

Check notice on line 56 in src/easydiffraction/datablocks/experiment/collection.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/collection.py#L56 

Unresolved comment '# TODO: Move to DatablockCollection?' (C100)

Check notice on line 18 in src/easydiffraction/datablocks/experiment/categories/background/base.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/background/base.py#L18 

Unresolved comment '# TODO: Consider moving to CategoryCollection'. (C100)

Check notice on line 89 in src/easydiffraction/datablocks/experiment/item/enums.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/item/enums.py#L89 

Unresolved comment '# TODO: Can supported values be defined based on the structure of peak/?' (C100)

Check notice on line 70 in src/easydiffraction/datablocks/experiment/collection.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/collection.py#L70 

Unresolved comment '# TODO: Move to DatablockCollection?' (C100)

Check notice on line 24 in src/easydiffraction/core/validation.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/core/validation.py#L24 

Unresolved comment '# TODO: MkDocs doesn't unpack types'. (C100)

Check notice on line 10 in src/easydiffraction/datablocks/experiment/categories/background/enums.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/background/enums.py#L10 

Unresolved comment '# TODO: Consider making EnumBase class with: default, description, ...' (C100)

Check notice on line 414 in src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py#L414 

Unresolved comment '# TODO: ???' (C100)

Check notice on line 374 in src/easydiffraction/datablocks/structure/categories/atom_sites/default.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/structure/categories/atom_sites/default.py#L374 

Unresolved comment '# TODO: Decide how to handle this case'. (C100)

Check notice on line 513 in src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py#L513 

Unresolved comment '# TODO: split into multiple methods'. (C100)

Check notice on line 58 in src/easydiffraction/datablocks/structure/collection.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/structure/collection.py#L58 

Unresolved comment '# TODO: Move to DatablockCollection?' (C100)

Check notice on line 216 in src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py#L216 

Unresolved comment '# TODO: Check this. AI suggest class'. (C100)

Check notice on line 333 in src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/data/bragg_pd.py#L333 

Unresolved comment '# TODO: Adapt following the _update method in bragg_sc.py'. (C100)

Check notice on line 53 in src/easydiffraction/datablocks/experiment/categories/background/chebyshev.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/easydiffraction/datablocks/experiment/categories/background/chebyshev.py#L53 

Unresolved comment '# TODO: the following pattern is valid for dict key'. (C100)
View more details on codefactor.io