Merged
Conversation
rozyczko
approved these changes
Dec 19, 2024
Member
rozyczko
left a comment
There was a problem hiding this comment.
The changes look benign, and do what needs to be done.
Agreed with the mocking issue - this is pre-existing and we need to find a general solution for proper mocking of those cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to use the newest versions of numpy and pint. Dropped Python 3.9, and included 3.13.
I had a lot of trouble with this part of parameter.py, on line 163
The problem was that the mock did not have a
_callback.fget()function. In this case, it returns something else:<MagicMock name='mock.fget()' id='2183984899984'>The comparison with
self._scalar.valueused to simply giveFalse, since they are clearly not identical. In Numpy 2, the result is ambiguous and gives an errorI can't quite tell if we need to update
valueto check if_callback.fget()actually produces a number, since it seems to only be an issue when mocking.I've updated the tests to mock
_callback.fget()as needed, but perhaps it's better to do it more generally?