Add type hints#5180
Draft
Flamefire wants to merge 1 commit into
Draft
Conversation
Member
|
If we target this for 6.0, we are planning to require python 3.9+ anyway |
Contributor
Author
|
The earlier we do that the better. And it is not breaking anything and through the module compatible with python 3.6 When branching of EB 6.x we can remove the imports and do a (mostly) trivial search&replace. The main work is adding those, keeping them correct and consistent with new/changed code. |
Member
|
that's fair |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft to show how it would like with type hints
It was (almost) entirely created by an AI agent (Opencode w/ Llama 3.3) to evaluate the usefulness before doing manual work.
Take as good examples:
Currently things like this are required:
In Python 3.9 types are subscriptable and
Unionis replaced by|:There are a static analyzers/linters to verify type hints, e.g.
mypyThrough that we can enforce type hints and ensure correctness on changes. Type-checking the test suite should provide good coverage of our interfaces.
cc @boegel