Skip to content

Include full shell command that failed in raised error#5074

Merged
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:shell-cmd-error
Jan 14, 2026
Merged

Include full shell command that failed in raised error#5074
boegel merged 2 commits intoeasybuilders:developfrom
Flamefire:shell-cmd-error

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

Allow to quickly inspect the command in the log, especially in test reports.

Allow to quickly inspect the command in the log, especially in test reports.
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 18, 2025

The full command can be quite long, that's exactly why we don't fully include it anymore since EasyBuild v5.0

@Flamefire
Copy link
Copy Markdown
Contributor Author

Makes sense for EasyBuildError. How about adding a log.error so one can see it in the log at least?

See https://gist.github.com/boegelbot/276c79e4105f6ed3d4cb633010ef30b3 for the motivation

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 19, 2025

Makes sense for EasyBuildError. How about adding a log.error so one can see it in the log at least?

See https://gist.github.com/boegelbot/276c79e4105f6ed3d4cb633010ef30b3 for the motivation

That makes sense I guess, since the full command that was run is quite far away from the error being logged, since the command output is in between

@Flamefire
Copy link
Copy Markdown
Contributor Author

Done. Did the same for the failing shell command in tests

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit d399df2 into easybuilders:develop Jan 14, 2026
40 checks passed
@Flamefire Flamefire deleted the shell-cmd-error branch January 14, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants