close stdout/stderr handles in run_shell_cmd and test teardown + remove duplication in toy_build tests#5050
Merged
boegel merged 4 commits intoeasybuilders:developfrom Apr 8, 2026
Merged
Conversation
Flamefire
force-pushed
the
toy-refactor
branch
5 times, most recently
from
8a97235 to
328593a
Compare
1 task
Flamefire
force-pushed
the
toy-refactor
branch
from
328593a to
cd41ff6
Compare
Flamefire
force-pushed
the
toy-refactor
branch
from
cd41ff6 to
41d31e4
Compare
Contributor
Author
|
Rebased |
Member
|
@Flamefire Needs conflict fixing |
Flamefire
force-pushed
the
toy-refactor
branch
from
41d31e4 to
df96819
Compare
Contributor
Author
|
Rebased to fix |
Flamefire
force-pushed
the
toy-refactor
branch
2 times, most recently
from
4d5fbd6 to
6045c01
Compare
Avoid the repaeted reads in almost every test.
The stdin/stdout/stderr handles need be closed by calling `communicate`. Otherwise the handles will be leaked and e.g. `test_run_shell_cmd_qa_trace` fails because it may capture a related warning.
boegel
changed the title
run_shell_cmd and test teardown + remove duplication in toy_build tests
Contributor
Author
|
I noticed there are > 200 similar cases in other test files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost every test case starts by getting the path to the test-folder, then to
toy-0.0.eband then reading this file.Not only makes this harder to read the (relevant part of) the test it also slows it down to read the same file in every test.
Hence I factored those out to file-level constants.
While testing I noticed we don't close the mocked stdout/stderr buffers and added that too