Skip to content

[QA] Add StructArmed to QA#10

Closed
samsonasik wants to merge 2 commits into
mainfrom
add-structarmed-to-qa
Closed

[QA] Add StructArmed to QA#10
samsonasik wants to merge 2 commits into
mainfrom
add-structarmed-to-qa

Conversation

@samsonasik
Copy link
Copy Markdown
Contributor

This PR adds StructArmed to github workflow static analysis for QA.

https://github.com/boundwize/structarmed

This PR uses the PSR1 and PSR4 preset, and already found violations that fixed and included in this PR for uppercase constants.

@samsonasik samsonasik requested a review from TomasVotruba May 30, 2026 03:47
@samsonasik
Copy link
Copy Markdown
Contributor Author

@TomasVotruba ready 👍

new EditorConfig(
indentStyle: null,
endOfLine: EndOfLine::Posix,
endOfLine: EndOfLine::POSIX,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These would be BC breaks, I prefer to keep it as it is.

@TomasVotruba
Copy link
Copy Markdown
Member

I like this package in Rector, but I want to avoid adding it in every other package.
The less tools to maintain to better 🙏

@samsonasik samsonasik deleted the add-structarmed-to-qa branch May 30, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants