Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43.
This PR implements a solution for treating the workflow-execution
CreateActionas a dedicatedro-crate:WorkflowRunentity across the Five Safes SHACL profiles.At a high level:
A hidden SHACL rule was added to the relevant TTL files to infer the triple
CreateAction -> rdf:type -> ro-crate:WorkflowRunfor theCreateActionwhoseinstrumentmatchesRootDataEntity -> mainEntity.All SHACL constraints that are really about the actual workflow run were then retargeted from generic
CreateActiontoWorkflowRun, with corresponding updates on shapes' names and messages.Tests were updated accordingly.
One important testing detail:
In the Python tests, the graph mutations still target entities of type
CreateAction, notWorkflowRun.This is intentional:
WorkflowRunis inferred by SHACL during validation, so it is safer for the tests to alter the sourceCreateActionnodes in the RO-Crate metadata graph.This remains correct as long as the tests are understood to target the specific
CreateActionthat is effectively the workflow run, and not any otherCreateActionthat may also be present in the crate.A separate consistency note:
prefixes.ttl, the RO-Crate namespace is exposed in SPARQL viarocrate(without the dash), while elsewhere in the codebase we also usero-crate.This did not originate in this PR, but it is something we may want to clean up in future to align prefix syntax across the codebase.