[#24574] Disable file watching on macOS and remove invalid InternalPtrData move#157
Open
Danipiza wants to merge 2 commits into
Open
[#24574] Disable file watching on macOS and remove invalid InternalPtrData move#157Danipiza wants to merge 2 commits into
Danipiza wants to merge 2 commits into
Conversation
…rData move Signed-off-by: danipiza <dpizarrogallego@gmail.com>
5226e16 to
15f5f43
Compare
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 60.41% 60.30% -0.11%
==========================================
Files 65 65
Lines 1945 1945
Branches 552 552
==========================================
- Hits 1175 1173 -2
- Misses 449 450 +1
- Partials 321 322 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves native macOS compatibility in
cpp_utils.Changes
FileWatcheron macOS by using a no-op backend under__APPLE__.FileWatcherHandlerbehavior explicit by logging that file watching is disabled on macOS.InternalPtrDatamove constructor, which attempted to move astd::shared_timed_mutex.Why
The bundled
filewatchbackend only supports Windows and Linux (inotify), so native macOS builds had no valid code path.Also,
InternalPtrDatatried to move a mutex:std::shared_timed_mutexis not movable by standard definitionError