[24046] Update security tests to use governance-based encryption configuration (backport #6277)#6396
Open
mergify[bot] wants to merge 1 commit into
Open
[24046] Update security tests to use governance-based encryption configuration (backport #6277)#6396mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
#6277) * Add reliability as a param to security tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Prepare XMLs to generate smime files for new tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding tests with access_sign in topic name Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in liveliness_protection_kind/rtps_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for SIGN access in discovery_protection_kind Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add tests for large data Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Modify performance tests to properly test access security Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Generate SMIME files from XML Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Remove old tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Relaxing requirements for best effor tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Uncrustify Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix some mistakes on the new tests and config files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Editing performance test files, they are ok now Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Fix compilation issues Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix large_data tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Update sign permissions files Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Attempt to fix transport+best_effort test cases Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Skip SIGN tests Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Adding some comments Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Add topic for profiling tests in performance tests xml and smime Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> * Refs #24046: Delete reliability matrix in test suite Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Avoid overload for clarification Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Update name of tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Create common methods to configure plugins Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Make basic test methods independent of Test suite class Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Add common communication test method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix only Auth security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Remove DataSharing from Security tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Use common methods for configuration Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Run with both reliability tests with RTPS or submessage encryption or sign Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Templatize test_basic_secure_communication method Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Do not run best_effort large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Uncrustify Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Fix Windows build Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Enable othercacert in 'fill_access' Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> * Refs #24046: Reduce large data tests Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Signed-off-by: Carlos Ferreira González <carlosferreira@eprosima.com> Co-authored-by: Carlos Ferreira González <carlosferreira@eprosima.com> (cherry picked from commit a1d550b) # Conflicts: # test/blackbox/common/BlackboxTestsSecurity.cpp # test/performance/video/main_VideoTest.cpp
Contributor
Author
|
Cherry-pick of a1d550b has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The properties rtps.participant.rtps_protection_kind, rtps.endpoint.submessage_protection_kind, and rtps.endpoint.payload_protection_kind are not parsed in the Fast-DDS source code. These properties are set in multiple blackbox security tests, but they have no effect on the actual encryption behavior.
The only valid way to configure RTPS/endpoint protection kinds is through the governance file with the Access Control plugin enabled.
The properties rtps.participant.rtps_protection_kind, rtps.endpoint.submessage_protection_kind, and rtps.endpoint.payload_protection_kind are not parsed in the Fast-DDS source code. These properties are set in multiple blackbox security tests, but they have no effect on the actual encryption behavior.
The only valid way to configure RTPS/endpoint protection kinds is through the governance file with the Access Control plugin enabled.
This PR includes the following features:
@Mergifyio backport 3.4.x 3.3.x 3.2.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A: New feature has been added to the
versions.mdfile (if applicable).N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #6277 done by [Mergify](https://mergify.com).