Skip to content

[#24288] Clarify default empty Partition behavior in Partition QoS#1237

Merged
Danipiza merged 1 commit intomasterfrom
hotfix/empty-partition
Mar 30, 2026
Merged

[#24288] Clarify default empty Partition behavior in Partition QoS#1237
Danipiza merged 1 commit intomasterfrom
hotfix/empty-partition

Conversation

@Danipiza
Copy link
Copy Markdown
Contributor

@Danipiza Danipiza commented Mar 24, 2026 •
edited
Loading

Description

This PR clarifies how the default partition works in DDS Partition QoS.

Changes:

  • Explicitly states that the default partition name is the empty string ("").
  • Clarifies that {} is equivalent to {""}.
  • Keeps tables aligned with the empty/default partition semantics.

PR FastDDS 5989

@Mergifyio backport 2.14.x 3.2.x 3.4.x 3.5.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • The Pro version badge has been added if the documented feature is exclusive to Fast DDS Pro.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Danipiza Danipiza force-pushed the hotfix/empty-partition branch from 062805c to 76c5348 Compare March 24, 2026 15:15
@zesk1999 zesk1999 self-requested a review March 25, 2026 12:47
zesk1999
zesk1999 requested changes Mar 25, 2026
View reviewed changes
@Danipiza Danipiza requested a review from zesk1999 March 25, 2026 14:53
zesk1999
zesk1999 approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@zesk1999 zesk1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Danipiza Danipiza added this to the v3.6.0 milestone Mar 26, 2026
@Danipiza Danipiza force-pushed the hotfix/empty-partition branch from 76c5348 to b88ea11 Compare March 26, 2026 08:07
@Danipiza
[#24288] Clarify default empty Partition behavior in Partition QoS
4f65a46 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza Danipiza force-pushed the hotfix/empty-partition branch from b88ea11 to 4f65a46 Compare March 30, 2026 10:21
@Danipiza Danipiza requested a review from richiprosima March 30, 2026 10:29
@cferreiragonz cferreiragonz removed the request for review from richiprosima March 30, 2026 12:17
@Danipiza Danipiza merged commit cb1bd60 into master Mar 30, 2026
5 checks passed
@Danipiza Danipiza deleted the hotfix/empty-partition branch March 30, 2026 12:19
@Danipiza
Copy link
Copy Markdown
Contributor Author

Danipiza commented Mar 30, 2026

@Mergifyio backport 2.14.x 3.2.x 3.4.x 3.5.x

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 30, 2026 •
edited
Loading

backport 2.14.x 3.2.x 3.4.x 3.5.x

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 30, 2026
@Danipiza @mergify
Clarify default empty Partition behavior in Partition QoS (#1237)
cd2a7ba 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
(cherry picked from commit cb1bd60)
@mergify mergify bot mentioned this pull request Mar 30, 2026
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Mar 30, 2026
@Danipiza @mergify
Clarify default empty Partition behavior in Partition QoS (#1237)
940fd8c 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
(cherry picked from commit cb1bd60)
@mergify mergify bot mentioned this pull request Mar 30, 2026
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Mar 30, 2026
@Danipiza @mergify
Clarify default empty Partition behavior in Partition QoS (#1237)
5137d1d 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
(cherry picked from commit cb1bd60)
@mergify mergify bot mentioned this pull request Mar 30, 2026
Open
9 tasks
mergify bot pushed a commit that referenced this pull request Mar 30, 2026
@Danipiza @mergify
Clarify default empty Partition behavior in Partition QoS (#1237)
22d81dc 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
(cherry picked from commit cb1bd60)
@mergify mergify bot mentioned this pull request Mar 30, 2026
Merged
9 tasks
Danipiza added a commit that referenced this pull request Mar 30, 2026
@Danipiza
Clarify default empty Partition behavior in Partition QoS (#1237)
ff861d5 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Danipiza added a commit that referenced this pull request Mar 30, 2026
@Danipiza
Clarify default empty Partition behavior in Partition QoS (#1237)
eebce48 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Danipiza added a commit that referenced this pull request Mar 30, 2026
@Danipiza
Clarify default empty Partition behavior in Partition QoS (#1237)
0dc604d 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Danipiza added a commit that referenced this pull request Mar 30, 2026
@Danipiza
Clarify default empty Partition behavior in Partition QoS (#1237)
76db63b 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Danipiza added a commit that referenced this pull request Mar 31, 2026
@Danipiza
Clarify default empty Partition behavior in Partition QoS (#1237)
e7d10cd 
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Danipiza added a commit that referenced this pull request Mar 31, 2026
@mergify @Danipiza
Clarify default empty Partition behavior in Partition QoS (#1237) (#1246
3b7ac7e 
)

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Co-authored-by: DannyP39 <98972125+Danipiza@users.noreply.github.com>
Danipiza added a commit that referenced this pull request Mar 31, 2026
@mergify @Danipiza
Clarify default empty Partition behavior in Partition QoS (#1237) (#1244
64d76a5 
)

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Co-authored-by: DannyP39 <98972125+Danipiza@users.noreply.github.com>
Danipiza added a commit that referenced this pull request Mar 31, 2026
@mergify @Danipiza
Clarify default empty Partition behavior in Partition QoS (#1237) (#1243
b7ffb29 
)

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Co-authored-by: DannyP39 <98972125+Danipiza@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zesk1999 zesk1999 zesk1999 approved these changes

Assignees

No one assigned

Labels

ci-pending

Projects

None yet

Milestone

v3.6.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

2 participants

@Danipiza @zesk1999