Dev/v8.x#891
Open
szmyd wants to merge 3 commits into
Open
Conversation
Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
szmyd
force-pushed
the
dev/v8.x
branch
2 times, most recently
from
c220c37 to
c334365
Compare
Ports the consumer-side timer change from stable/v7.x forward to v8. Upstream ef9ab9d upgrades the 8 recurring timer callbacks (cp_mgr, resource_mgr, log_dev, raft_repl_service) from void(void*) to void(void*, uint64_t exp_count), logging once when the timerfd fell behind (exp_count > 1) instead of letting the callback fire N times -- the consumer half of iomgr's SDSTOR-22330. Resolution notes (the literal patch did not apply cleanly): - conanfile.py: kept v8.x (homestore 8.0.0, iomgr/[^13.0]@oss/dev, sisl 14.5, nuraft_mesg 5.0); dropped upstream's 7.5.10 / iomgr 12.0.3 bumps -- v8 is already on iomgr 13, whose backward-compat overloads make this an enhancement rather than a compile fix. - cp_mgr cp-timer: kept v8's coroutine body detail::detach(trigger_cp_flush(false)) and added the exp_count guard/log around it. - The other 7 callbacks took the upstream form (bodies were unchanged in v8). - .github/workflows/merge_build.yml: kept v8.x's reworked workflow; the unrelated ChainBuild commit (55ed28e) is intentionally not adopted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.