Skip to content

dump chunk state in http apis#428

Merged
xiaoxichen merged 1 commit into
eBay:stable/v4.xfrom
Besroy:add_chunk_statet
Jun 5, 2026
Merged

dump chunk state in http apis#428
xiaoxichen merged 1 commit into
eBay:stable/v4.xfrom
Besroy:add_chunk_statet

Conversation

@Besroy
Copy link
Copy Markdown
Contributor

@Besroy Besroy commented Jun 5, 2026

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds virtual chunk state visibility to existing HTTP debug endpoints so operators can see the current ChunkState when dumping a chunk or shard. It also bumps the Conan package version.

Changes:

  • Add vchunk_state to /api/v1/chunk/dump response payload.
  • Add vchunk_state to /api/v1/shard/dump response payload.
  • Bump conanfile.py version from 4.1.13 to 4.1.14.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/lib/homestore_backend/hs_http_manager.cpp Adds vchunk_state field to chunk/shard dump HTTP APIs.
conanfile.py Bumps package version for the new API output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/lib/homestore_backend/hs_http_manager.cpp Outdated
Comment thread src/lib/homestore_backend/hs_http_manager.cpp Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

Comment thread src/lib/homestore_backend/hs_http_manager.cpp Outdated
Comment thread src/lib/homestore_backend/hs_http_manager.cpp
Comment thread src/lib/homestore_backend/hs_http_manager.cpp Outdated
Comment thread src/lib/homestore_backend/hs_http_manager.cpp
Comment thread src/lib/homestore_backend/hs_http_manager.cpp Outdated
Comment thread src/lib/homestore_backend/hs_http_manager.cpp
@Besroy Besroy force-pushed the add_chunk_statet branch from bdcea85 to cc7da09 Compare June 5, 2026 08:38
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (stable/v4.x@9fbad3e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_http_manager.cpp 0.00% 7 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@              Coverage Diff               @@
##             stable/v4.x     #428   +/-   ##
==============================================
  Coverage               ?   48.63%           
==============================================
  Files                  ?       36           
  Lines                  ?     5387           
  Branches               ?      676           
==============================================
  Hits                   ?     2620           
  Misses                 ?     2506           
  Partials               ?      261           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiaoxichen xiaoxichen merged commit 5f757ac into eBay:stable/v4.x Jun 5, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants