SDSTOR-22424: Redo Destroy PG#426
Open
JacksonYao287 wants to merge 1 commit into
Open
Conversation
JacksonYao287
force-pushed
the
fix-issues-of-destroy-pg
branch
from
f1b7282 to
0e0a76e
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stable/v4.x #426 +/- ##
==============================================
Coverage ? 87.50%
==============================================
Files ? 1
Lines ? 40
Branches ? 7
==============================================
Hits ? 35
Misses ? 0
Partials ? 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JacksonYao287
force-pushed
the
fix-issues-of-destroy-pg
branch
from
0e0a76e to
94e4d7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 there is a case that a pg is marked as destroyed, but before all the pg resource is cleanup, crash happens. in this case , we need to redo pg destroy to cleanup those stale pg resource.
2 if br happens, we need to reset latch_lsn and no_space_left info, which in memory only and will leads to unexpected behavior after br