fix(envd): require sha256 for upgrade body - #3536
Open
SashaMIT wants to merge 1 commit into
Open
Conversation
Require X-Envd-Upgrade-Sha256 (lowercase hex) for non-empty POST /upgrade bodies and verify before writing envd.next. Orchestrator CallEnvdUpgrade now attests the streamed binary digest so content integrity is enforced alongside auth and the fixed-path allowlist. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Envd-Upgrade-Sha256(lowercase hex SHA-256 of the request body) whenPOST /upgradecarries a non-empty body; reject with 400 if the header is missing, malformed, or mismatches — before writing/usr/bin/envd.next.CallEnvdUpgradehashes the local envd binary and sets the header when streaming the body.Test plan
go test ./internal/services/process/ -run WriteUpgradeBinary(packages/envd) — missing / malformed / wrong / correct hash pathsgo buildpackages/envdgo testpackages/orchestrator/pkg/sandbox (TestCallEnvdUpgrade_SetsBodySHA256Header, linux) — not executable on darwin host hereMade with Cursor