Use by-default memfd and background copy#3011
Conversation
Make memfd for guest memory and background copies during pause/snapshot the default. The behaviour is still controlled by LaunchDarkly (when present) but the default now is to use these two features. Also, flip -use-memfd to -disable-memfd flag in create-build and resume-build, so that local testing uses memfd by default and apply the same flip in CI testing environments. Signed-off-by: Babis Chalios <babis.chalios@e2b.dev>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
PR SummaryMedium Risk Overview Reviewed by Cursor Bugbot for commit bfe9011. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Code Review
This pull request enables memfd-backed guest memory and background copying by default. It replaces the previous enablement flags and environment variables (use-memfd, TESTS_USE_MEMFD) with disablement alternatives (disable-memfd, TESTS_DISABLE_MEMFD) across the orchestrator, build tools, and GitHub actions. There are no review comments to address, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
dobrac
left a comment
There was a problem hiding this comment.
make sure to properly specify the FC version dependency
Make memfd for guest memory and background copies during pause/snapshot the default. The behaviour is still controlled by LaunchDarkly (when present) but the default now is to use these two features.
Also, flip -use-memfd to -disable-memfd flag in create-build and resume-build, so that local testing uses memfd by default and apply the same flip in CI testing environments.