Open
Conversation
- Removed unused imports and simplified the confirmation logic in `route.ts`. - Introduced functions to determine if a URL is relative or from an external origin. - Updated the confirmation schema to accept a string for the `next` parameter. - Enhanced logging for the confirmation process and added a redirect to the confirmation page for same-origin requests. - Added `CONFIRM` URL to the `AUTH_URLS` configuration. - Refactored the builds repository to export functions directly. This improves the clarity and maintainability of the authentication flow.
- Updated the confirmation page to utilize a new `verifyOtp` function for handling OTP verification. - Replaced TRPC mutation with a direct API call for improved clarity and control over the verification process. - Enhanced error handling and user feedback on the confirmation page. - Removed the deprecated `auth` router and adjusted related imports accordingly. - Improved logging for the OTP verification process in the repository. These changes streamline the authentication flow and improve maintainability.
- Updated the `VerifyOtpResponse` interface to require a `redirectUrl` for successful OTP verification. - Simplified error handling in the `verifyOtp` function to throw a generic error message when verification fails. - Improved the confirmation page's mutation success handling to directly push the `redirectUrl` without additional checks. - Introduced a new function to build error redirect URLs, enhancing user feedback for invalid verification attempts. These changes streamline the OTP verification process and improve user experience during authentication.
…security - Updated the `buildRedirectUrl` function to utilize the dashboard origin for safe redirects, preventing open redirect vulnerabilities. - Introduced a check for external origins in the OTP verification process, rejecting requests from untrusted sources. - Enhanced error logging for invalid OTP requests and improved user feedback with a dedicated error redirect URL. - Simplified the handling of search parameters in the redirect URL construction. These changes strengthen the security and user experience during the OTP verification flow.
- Moved the `normalizeOrigin` and `isExternalOrigin` functions to the `auth.ts` utility file for better organization and reusability. - Updated the `confirm` and `verify-otp` routes to utilize the new `isExternalOrigin` function, improving the handling of redirect URLs. - Removed redundant implementations of origin normalization from the routes, streamlining the codebase. These changes improve code maintainability and enhance security checks during the authentication process.
…om/e2b-dev/dashboard into integrate-design-system-primitives
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87416f20fc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Button
You don’t need to specify gap anymore. It’s baked in.
You don’t need to provide colors, neither for text nor icon
There was a mistake in ‘icon’ variant for a button → should be size-4 everywhere. You don’t need to provide sizes for icons ideally.
Added link button variant as that was not in the design system but it’s used throughout the dashboard. Instead of orange, we will use 80% opacity. More decent, on-par with our landing page
Introduced an IconButton component for buttons that are only icon. They differ slightly in styling (e.g. a color shows upon hover) and it made more sense than to add multiple new variants to already big Button. Matches our Figma design system.
Other
Arc_-_2026-02-24_at_12.17.28.mp4
Arc_-_2026-03-05_at_22.08.09.mp4
Arc_-_2026-03-10_at_12.33.49.mp4