Skip to content

Keep integration attribution on connection config#1459

Open
matthewlouisbrockman wants to merge 2 commits into
mainfrom
attribution/private-connection-config
Open

Keep integration attribution on connection config#1459
matthewlouisbrockman wants to merge 2 commits into
mainfrom
attribution/private-connection-config

Conversation

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor

moves integration attirbution to more private thing to avoid confusing people with first class kwargs

@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e5b35b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
e2b Patch
@e2b/python-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cursor

cursor Bot commented Jun 18, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Narrow API/typing change around optional User-Agent attribution; no auth or request-path logic changes beyond stopping per-call integration overrides.

Overview
Integration attribution (the string appended to User-Agent for wrapper SDKs) is no longer part of the shared ConnectionOpts / per-call API option types. It is only accepted when constructing ConnectionConfig (ConnectionConfigOpts in JS; constructor-only in Python).

In JS, integration moved off ConnectionOpts onto ConnectionConfigOpts, and the package exports that type. Sandbox and other APIs that take ConnectionOpts no longer surface integration as a first-class kwarg; tests set attribution via new ConnectionConfig({ integration: ... }) instead.

In Python, integration was removed from ApiParams, so get_api_params() no longer reads or returns it and per-call overrides cannot change attribution. User-Agent is rebuilt from the config’s stored integration when merging headers, and a caller-supplied User-Agent in headers is preserved when integration is unset.

Reviewed by Cursor Bugbot for commit e5b35b8. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Package Artifacts

Built from 302ef6c. Download artifacts from this workflow run.

JS SDK (e2b@2.30.6-attribution-private-connection-config.0):

npm install ./e2b-2.30.6-attribution-private-connection-config.0.tgz

CLI (@e2b/cli@2.12.3-attribution-private-connection-config.0):

npm install ./e2b-cli-2.12.3-attribution-private-connection-config.0.tgz

Python SDK (e2b==2.29.5+attribution-private-connection-config):

pip install ./e2b-2.29.5+attribution.private.connection.config-py3-none-any.whl

@mishushakov mishushakov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

Comment thread packages/js-sdk/src/connectionConfig.ts Outdated
Comment thread packages/js-sdk/tests/sandbox/rpcHeaders.test.ts Outdated
Comment thread packages/js-sdk/tests/connectionConfig.test.ts
Comment thread packages/python-sdk/e2b/connection_config.py
Comment thread packages/python-sdk/e2b/connection_config.py

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8822e93. Configure here.

Comment thread packages/python-sdk/e2b/connection_config.py
@matthewlouisbrockman matthewlouisbrockman force-pushed the attribution/private-connection-config branch from 8822e93 to d5f44bd Compare June 23, 2026 01:54
Comment thread packages/python-sdk/e2b/connection_config.py Outdated
Comment thread packages/python-sdk/e2b/connection_config.py Outdated
@matthewlouisbrockman matthewlouisbrockman force-pushed the attribution/private-connection-config branch from d5f44bd to e5b35b8 Compare June 23, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants