chore: fix cwv link to solid-start - #394
Closed
birkskyum wants to merge 1 commit into
Closed
Conversation
Collaborator
|
@birkskyum Thank you for this. I noticed that a few of the links in the HTTP archive data are broken due to the data coming from Google, not us. I think it would be better to fix this in our import function than in the docs. We can fix this, but I'm happy for you to update the PR. It's a larger job, as you need to fix the importer and the data. Let me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the link in this table to SolidStart is broken because it links
/solidstartand it should be/solid-starthttps://frameworks.e18e.dev/run-time/#core-web-vitals