Skip to content

Remove Node Modules Prod - #379

Open
AlexanderKaran wants to merge 1 commit into
mainfrom
remove-node-modules-prod-test
Open

Remove Node Modules Prod#379
AlexanderKaran wants to merge 1 commit into
mainfrom
remove-node-modules-prod-test

Conversation

@AlexanderKaran

@AlexanderKaran AlexanderKaran commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Add some feedback from @danielroe while reviewing Nuxt tests:

"prod node modules" size isn't fair across frameworks. nuxt is a dependency simply by convention (sveltekit is a devDep by convention). nuxt is never shipped into production; it's a build tool like vite.

Removed the test to keep them fair

Part of #196

@AlexanderKaran
AlexanderKaran requested a review from 43081j as a code owner August 8, 2026 10:41
@cloudflare-workers-and-pages

Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
framework-tracker 8168a1c Commit Preview URL

Branch Preview URL
Aug 08 2026, 10:40 AM

@43081j 43081j left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. most or all of them output static builds i guess, i.e. no node modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants