You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove ClientSide Router as it's not needed for client-side and just ops in view transitions. In most frameworks, you have to opt in for view transitions, so it's not fair to add it for Astro.
@dreyfus92 Please add a better description if I did a shit job above lol
quick note on why we decided to remove <Clientrouter />:
<Clientrouter /> and csr are two different things. what actually makes this test client-only is the directive client:only="react" on the table island not clientrouter. that's what keeps the table out of the initial html, and lighthouse waiting on table tbody after hydration/render is the behavior we care about.
clientrouter is basically just "hey astro, enable view transitions api". it gives mpa apps that soft spa-like navigation feel, but it's optional. it doesn't enable csr, and you don't need it for a client only island to work.
so including it here felt a bit off because:
we're benchmarking client-rendered ui, not optional navigation/transitions most other frameworks in the suite don't include transition/router behavior by default for csr (usually opt-in) keeping it would bake in an astro-specific optional feature that isn't really part of a typical csr setup
the react + client:only approach, react isn't required for client-only in astro (you could do a client <script> or another integration), but it's a reasonable default and closer to how a lot of astro apps ship interactive islands. a plain script-generated table would be more baseline html/js and less "astro-y", so imo keeping react here makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dreyfus92 Please add a better description if I did a shit job above lol
Another fix for #194
Might be able to close the Astro check now