This repository was archived by the owner on Nov 29, 2022. It is now read-only.
Fixes gestures not passing through UITableViewWrapperView on iOS 7#126
Open
bartvandendriessche wants to merge 1 commit intodzenbot:masterfrom
Conversation
This fixes dzenbot#47 In a nutshell, this pull request toggles `UITableViewWrapperView`'s `userInteractionEnabled` property off or on when the `emptyDataSetView` appears or disappears. The main concern here I suppose is the check for "UITableViewWrapperView" since that is a private API. This call is guarded by a version check, so shouldn't break in future releases, but I'm not sure if checking for this class could cause an app to be rejected. For what it's worth, validating an Archive containing this code didn't cause any private API flags to be raised.
|
What's the status of this? |
Owner
|
This is too hacky IMHO. There must be a better way of doing this. |
Contributor
Author
|
The apps I'm using this in no longer support iOS 7 nowadays, but this is basically an issue for everyone who supports iOS 7 and wants the empty data set button to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #47
In a nutshell, this pull request toggles
UITableViewWrapperView'suserInteractionEnabledproperty off or on when theemptyDataSetViewappears or disappears.The main concern here I suppose is the check for "UITableViewWrapperView" since that is a private API. This call is guarded by a version check, so shouldn't break in future releases, but I'm not sure if checking for this class could cause an app to be rejected.
For what it's worth, validating an Archive containing this code didn't cause any private API flags to be raised.