fix: Restore Rich markup escaping lost in refactoring#151
Merged
Conversation
The refactor commits (4f19573, 0fb3d1b) moved display logic from phabfive/maniphest.py to phabfive/cli.py but failed to carry over the rich.markup.escape() fix from PR #137. This restores the escaping by: - Adding _escape_for_rich() helper function - Escaping user content in display_task_rich() and display_task_tree() Fixes regression of #135 (MarkupError on [/path] patterns) and #136 (silent stripping of [bug] tags). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
holmboe
force-pushed
the
fix/rich-tags-exceptions
branch
from
be3fd54 to
9b37d11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rich.markup.escape()functionality that was lost when display logic was moved fromphabfive/maniphest.pytophabfive/cli.pyduring refactoring (commits 4f19573, 0fb3d1b)_escape_for_rich()helper function to safely escape user contentdisplay_task_rich()anddisplay_task_tree()functionsProblem
The refactor commits moved display logic to
cli.pybut failed to carry over the escape fix from PR #137. This caused:MarkupErrorcrash on[/path]patterns (interpreted as closing tag)[bug]tags from titles (interpreted as invalid style)Test plan
phabfive maniphest show T525displays without crash[bug]prefix show the tag correctly🤖 Generated with Claude Code