Open
Conversation
deft-browse/deft-browse.dylan
Outdated
Member
There was a problem hiding this comment.
minor: indentation a bit off in these two lines. no space needed in ")) )"
Does this need a TODO to take the module name as an argument to the "subclasses" command? Or maybe better would be to have a standard notation such as "[[my-lib:]my-mod:]my-name"? Or just search all modules for the name?
Member
Author
|
I think we should add two flags to the command:
what do you think? |
Member
|
Module and library filters sound good. I think what Carl said about only printing sub-trees once should be the default behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment it's pretty basic, any idea how I could make this more useful?
Example:
specify depth: